Repository navigation
[CP-stable]fix(tool): remove redundant --enable-experiment=record-use flag - #192318
Conversation
…ter#190475) When compiling web targets (dart2js and dart2wasm) or running dry runs with the record-use feature flag enabled, flutter_tools explicitly passed --enable-experiment=record-use to the compiler. Since record-use is enabled by default in recent Dart SDKs, passing this flag caused warning spam during standard compilation and dry runs. * Remove --enable-experiment=record-use from Dart2JSTarget and Dart2WasmTarget in web.dart. * Remove expected flag from test commands in web_test.dart and web_dry_run_test.dart. Fixes flutter#190465
|
@kevmoo please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
Bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the '--enable-experiment=record-use' compiler flag from both Dart2JSTarget and Dart2WasmTarget build targets when record-use is enabled. Corresponding test expectations in web_dry_run_test.dart and web_test.dart have been updated to match this change. There are no review comments, and I have no feedback to provide.
walley892
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/192318, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
@bkonyi, could you look into the test errors please? |
|
@walley892 @bkonyi – I think I kicked the right bits and we're good to go! |
5743177
into
flutter:flutter-3.47-candidate.0
4 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
#190465
Impact Description:
In Dart 3.7 (shipped in Flutter 3.47),
record-usewas enabled by default. Passing--enable-experiment=record-useemitted a non-fatal warning onstderr. Becauseflutter_toolsevaluatedif (stderr.isNotEmpty) result = 'failure', this non-fatal compiler warning caused dry runs to bypassstdoutfindings parsing and omitE00–E17package incompatibility telemetry keys.Changelog Description:
#190465 When running WebAssembly dry-run builds on Web, remove redundant experiment flag warning that dropped telemetry error findings.
Workaround:
Is there a workaround for this issue?
None. Telemetry payload parameters were dropped internally by the CLI tool.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
flutter build web --no-wasm-dry-runvs dry-run mode on a project with legacy web dependencies (dart:htmlorpackage:js).Event.flutterWasmDryRunPackageemitsresult: "findings"and attachesE...error keys withoutstderrwarning spam.