Repository navigation
[win32] Remove the predicate from TimerThread condition variable - #193181
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates TimerThread::TimerThreadMain in task_runner_window.cc to simplify the wait logic. It replaces the predicate lambda in cv_.wait_until with a direct call, followed by an explicit check to continue the loop if the current time is before next_fire_time_. There are no review comments, and I have no feedback to provide.
github-actions
Bot
added
engine
76272c8 to
ca62856
Compare
flutter-dashboard
Bot
removed
the
autosubmit
knopp
added
the
cp: stable
2 participants
Right now we're not checking the next_fire_time_ in the predicate, which means that when scheduling an earlier timer, we signal the condition variable but because of the missing check it is ignored as spurious wake-up.
This is the second time we got the predicate wrong. The loop can handle spurious wake-ups just fine, so it's probably best to remove the predicate.
This might account for some of the win32 tests flakiness.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.