Repository navigation
fix: flutter analyze reporting the same issue multiple times - #193279
Merged
auto-submit[bot] merged 2 commits intoSep 24, 2026
Merged
Conversation
The language server republishes a file's full set of diagnostics whenever they change, e.g. when an analyzer plugin reports after the Dart analysis results. AnalyzeOnce appended every publish, so a file published N times had its issues reported N times. Keep only the latest set per file, as AnalyzeContinuously already does. Fixes: flutter#192587
github-actions
Bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the analysis error handling in 'analyze_once.dart' by using a map to store errors by file, ensuring that only the latest diagnostics are reported. A corresponding test case has been added to 'analyze_test.dart' to verify this behavior. The reviewer suggested renaming the closure parameter in the 'expand' method to 'fileErrors' to avoid shadowing the outer 'errors' variable and to improve code readability.
srawlins
approved these changes
Sep 24, 2026
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 25, 2026
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
flutter analyzereporting the same issue multiple times.The analysis server sends the complete list of diagnostics for a file in a
textDocument/publishDiagnosticsnotification, and publishes the file again whenever that list changes, for example once for the Dart analysis results and again when an analyzer plugin reports for it.AnalyzeOnceappended the errors from every notification, so an issue in a file that was published three times was reported three times.This change keeps only the latest diagnostics for each file, the same way
AnalyzeContinuouslyalready does, and adds a test that publishes diagnostics for the same file twice.Fixes: #192587
Pre-launch Checklist
///).