Skip to content

Remove more instances of deprecated withOpacity - #193559

Merged
auto-submit[bot] merged 6 commits into
flutter:masterfrom
AbdeMohlbi:opacity_removal_2
Oct 11, 2026
Merged

auto-submit[bot] merged 6 commits into
flutter:masterfrom
AbdeMohlbi:opacity_removal_2

Conversation

@AbdeMohlbi

@AbdeMohlbi AbdeMohlbi commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Similar PRs:

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: routes Navigator, Router, and related APIs. labels Sep 30, 2026
@AbdeMohlbi AbdeMohlbi added the CICD Run CI/CD label Sep 30, 2026
@AbdeMohlbi AbdeMohlbi changed the title Remove more of deprecated withOpacity Remove more instances of deprecated withOpacity Oct 1, 2026
@AbdeMohlbi
AbdeMohlbi marked this pull request as ready for review October 1, 2026 08:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates usages of withOpacity to withValues(alpha: ...) across painting and widget files, as well as their corresponding tests. Feedback on the changes identifies an inconsistency in gradient_test.dart where withValues(alpha: 0.5) is applied to colors that already have an alpha value of 0x80 in their hex representation, rather than using the original base colors.

Comment thread packages/flutter/test/painting/gradient_test.dart

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AbdeMohlbi AbdeMohlbi added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 11, 2026
Merged via the queue into flutter:master with commit badb64c Oct 11, 2026
23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants