Repository navigation
Update changelog for the single CP for this stable hotfix release. - #193959
auto-submit[bot] merged 2 commits into
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a changelog entry for Flutter version 3.47.7 regarding an iOS OverlayPortal accessibility issue. Feedback suggests rephrasing the entry to describe the fix rather than the symptoms, starting with 'Fixed an issue where...', to align with the repository's standard changelog format.
| ## Flutter 3.47 Changes | ||
|
|
||
| ### [3.47.7](https://github.com/flutter/flutter/releases/tag/3.47.7) | ||
| - [flutter/193420](https://github.com/flutter/flutter/pull/193420) When a route shows an OverlayPortal on iOS, accessibility frames are shrunk by the device pixel ratio and anchored to the top-left, so VoiceOver focus and XCUITest taps miss the visible controls. |
There was a problem hiding this comment.
The changelog entry describes the bug symptoms rather than the fix itself. To maintain consistency with other entries in the changelog (which typically start with 'Fixed...'), it should be rephrased to describe what was fixed.
| - [flutter/193420](https://github.com/flutter/flutter/pull/193420) When a route shows an OverlayPortal on iOS, accessibility frames are shrunk by the device pixel ratio and anchored to the top-left, so VoiceOver focus and XCUITest taps miss the visible controls. | |
| - [flutter/193420](https://github.com/flutter/flutter/pull/193420) Fixed an issue where, when a route shows an OverlayPortal on iOS, accessibility frames are shrunk by the device pixel ratio and anchored to the top-left, causing VoiceOver focus and XCUITest taps to miss the visible controls. |
| ## Flutter 3.47 Changes | ||
|
|
||
| ### [3.47.7](https://github.com/flutter/flutter/releases/tag/3.47.7) | ||
| - [flutter/193420](https://github.com/flutter/flutter/pull/193420) When a route shows an OverlayPortal on iOS, accessibility frames are shrunk by the device pixel ratio and anchored to the top-left, so VoiceOver focus and XCUITest taps miss the visible controls. |
There was a problem hiding this comment.
This should be a link to the issue (#182604), not the PR.
justinmc
added
the
autosubmit
632f36e
into
flutter:flutter-3.47-candidate.0
2 participants
Updates the changelog for the 3.47.7 stable hotfix release. The only cherry pick was #193420.