Repository navigation
[Windows] Set window title from setApplicationSwitcherDescription - #194214
Draft
paul-geoghegan wants to merge 1 commit into
Draft
paul-geoghegan wants to merge 1 commit into
paul-geoghegan wants to merge 1 commit into
Conversation
The Windows embedder did not handle SystemChrome.setApplicationSwitcherDescription, so the window title stayed as the application name. Handle the method and set the title of the top-level window. Part of flutter#178024
github-actions
Bot
added
engine
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows embedder didn't handle SystemChrome.setApplicationSwitcherDescription, so the window title stayed as the application name. This sets the title of the top-level window from the label. Same change as the Linux PR.
This has not been built or run on Windows yet.
Part of #178024
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.