Repository navigation
Conversation
MultiChildRenderObjectElement.mount assigned _children only after every child mounted, so when a child threw while mounting, the clean-up of the failed mount could not visit the siblings mounted before it. They stayed registered as dependents of the inherited widgets above, and removing one of those later failed the '_dependents.isEmpty' assertion. Co-Authored-By: Claude Opus 5.5 <[email protected]>
github-actions
Bot
added
the
framework
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a child of a
MultiChildRenderObjectWidgetthrows while mounting (ininitState,didChangeDependencies, aTabBarwith noTabController, etc.), the siblings that already mounted are never deactivated.MultiChildRenderObjectElement.mountassigns_childrenonly after the loop finishes, so_deactivateFailedSubtreeRecursivelyhits aLateInitializationErrorinvisitChildren, which is swallowed. Those siblings stay registered as dependents of the inherited widgets above, and removing one of those inherited widgets later fails'_dependents.isEmpty': is not true.This PR assigns the children that did mount to
_childrenbefore rethrowing, so the existing failed-mount clean-up deactivates them. The happy path is unchanged.Fixes #194273
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.🤖 Generated with Claude Code