Repository navigation
Enhance SizeTransition docs - #19721
Merged
Merged
Conversation
gspencergoog
force-pushed
the
size_transition_docs
branch
from
July 24, 2018 19:20
3231546 to
5d32e7b
Compare
Hixie
reviewed
Jul 24, 2018
| /// | ||
| /// For a widget that automatically animates between the sizes of two children, | ||
| /// fading between them, see [AnimatedCrossFade]. | ||
| /// `SizeTransition` acts as a clip region that animates either its width or |
Hixie
reviewed
Jul 24, 2018
| /// | ||
| /// For a widget that automatically animates between the sizes of two children, | ||
| /// fading between them, see [AnimatedCrossFade]. | ||
| /// `SizeTransition` acts as a clip region that animates either its width or |
Contributor
Author
There was a problem hiding this comment.
clip rect, I mean.
Contributor
There was a problem hiding this comment.
i guess @liyuqian will change that when he does his patch to remove clipping everywhere
Hixie
reviewed
Jul 24, 2018
| /// For a widget that automatically animates between the sizes of two children, | ||
| /// fading between them, see [AnimatedCrossFade]. | ||
| /// `SizeTransition` acts as a clip region that animates either its width or | ||
| /// height, depending upon the value of [axis]. The alignment of the child along |
Hixie
reviewed
Jul 24, 2018
| /// given, so be sure to put it in a context where it can change size. For | ||
| /// instance, if you place it into a [Container] with a fixed size, then the | ||
| /// `SizeTransition` will not be able to change size, and will appear to do | ||
| /// nothing. |
Contributor
|
|
…r into size_transition_docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated documentation of SizeTransition, since I found it less than intuitive.
I added some constructor asserts to make the (existing) contract more clear.