Repository navigation
Fix traversal order issues caused by intersecting or overlapping child rects - #21235
Merged
Merged
Conversation
goderbauer
reviewed
Aug 30, 2018
goderbauer
left a comment
goderbauer
left a comment
Member
There was a problem hiding this comment.
LGTM
Even in your moment of triumph you'll have to add a test 😃
yjbanov
reviewed
Aug 30, 2018
| List<SemanticsNode> _childrenInDefaultOrder(List<SemanticsNode> children, TextDirection textDirection) { | ||
| final List<_BoxEdge> edges = <_BoxEdge>[]; | ||
| // Using a small offset value to shrink child rects removes overlapping cases. | ||
| const Offset smallOffset = Offset(0.1, 0.1); |
Contributor
There was a problem hiding this comment.
Should this also be done in sortedWithinVerticalGroup? However, rather than duplicating the logic in multiple places, can we Rect.deflate by a delta and use the same rectangles in all places?
Contributor
Author
There was a problem hiding this comment.
Added for the sortedWithinVerticalGroup. Since we get the rects as is from the semantics nodes I don't think we can/should mutate them there.
Contributor
Author
|
LGTM for real? |
yjbanov
approved these changes
Aug 31, 2018
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17375