Repository navigation
Add basic codegen app to be used for integration testing and benchmarks - #27257
Merged
Merged
Conversation
yjbanov
reviewed
Jan 29, 2019
zoechi
added
a: tests
added 8 commits
February 1, 2019 12:53
Contributor
Author
|
cc @yjbanov PTAL |
yjbanov
approved these changes
Feb 7, 2019
Contributor
|
|
jonahwilliams
changed the title
jonahwilliams
changed the title
Contributor
Author
|
Adding @zanderso for tool changes |
Contributor
Author
|
Unless anyone has any comments, I will land this tonight after the build is green |
yjbanov
approved these changes
Feb 13, 2019
yjbanov
left a comment
yjbanov
left a comment
Contributor
There was a problem hiding this comment.
I only have some nits. LGTM.
| import 'runner.dart' as runner; | ||
| import 'src/base/context.dart'; | ||
| // The build_runner code generation is provided here to make it easier to | ||
| // avoid introducing the dependency into google3. |
Contributor
There was a problem hiding this comment.
nit: This aspect might be useful to others companies, so I'd phrase it as "avoid introducing the dependency into build systems that use their own codegen methods, such as Google's internal infrastructure".
Contributor
Author
There was a problem hiding this comment.
This is only an issue for google3 because the build packages are not synced. In theory it could run...
| verboseHelp: verboseHelp); | ||
| verboseHelp: verboseHelp, | ||
| overrides: <Type, Generator>{ | ||
| // The build runner instance is not supported in google3. |
zanderso
approved these changes
Feb 14, 2019
This was referenced Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generatecommand, which runs code generation without compiling to kernel.Basic flutter app which brews coffee on button press, requires dart inject code generation to run.
Work towards #27141