Skip to content

Fix the length of the valueHelp on the --sample option for the create command, and turn on wrapping. - #28264

Merged
gspencergoog merged 2 commits into
flutter:masterfrom
gspencergoog:fix_option
Feb 21, 2019
Merged

gspencergoog merged 2 commits into
flutter:masterfrom
gspencergoog:fix_option

Conversation

@gspencergoog

@gspencergoog gspencergoog commented Feb 21, 2019 •

Copy link
Copy Markdown
Contributor

The wrapping for some commands was never actually turned on, so this turns it on.

Also, it shortens the valueHelp for the --sample option to be just "id" instead of "the sample ID of the desired sample from the API documentation website (http://docs.flutter.io)", which was causing the line to get far too long.

Fixes #23074

@zoechi zoechi added tool Affects the "flutter" command-line tool. See also t: labels. d: examples Sample code and demos labels Feb 21, 2019

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog
gspencergoog merged commit b316940 into flutter:master Feb 21, 2019
@gspencergoog
gspencergoog deleted the fix_option branch May 15, 2019 16:31
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter cli output should have a constrained character width

4 participants