Skip to content

Log pub return code on failure on Windows - #28356

Merged
cbracken merged 1 commit into
flutter:masterfrom
cbracken:log-errorlevel
Mar 1, 2019
Merged

cbracken merged 1 commit into
flutter:masterfrom
cbracken:log-errorlevel

Conversation

@cbracken

Copy link
Copy Markdown
Member

When pub fails, log the %ERRRORLEVEL% to help diagnose the root cause of
the pub failure.

When pub fails, log the %ERRRORLEVEL% to help diagnose the root cause of
the pub failure.

@bkonyi bkonyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I guess.

shipit

@zoechi zoechi added tool Affects the "flutter" command-line tool. See also t: labels. platform-windows Building on or for Windows specifically labels Feb 23, 2019

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do we print out the same is the Bash script for Linux/Mac? Should we make the same change there?

@cbracken
cbracken merged commit cccf44f into flutter:master Mar 1, 2019
@cbracken
cbracken deleted the log-errorlevel branch March 1, 2019 07:53
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-windows Building on or for Windows specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants