Repository navigation
Fix backspace and clear length in AnsiStatus - #28477
Merged
Merged
Conversation
Might be related to flutter#26922 Without the fix, the newly added test failed with the following error: ``` 00:07 +24 -4: Spinners AnsiStatus works for fuchsia [E] Expected: a non-negative value Actual: <-1> Which: is not a non-negative value The following line has overflow backtraces: ⡿ (This is taking an unexpected ⣟ (This is taking an unexpected ⣯ (This is taking an unexpected ⣷ (This is taking an unexpected ⣾ (This is taking an unexpected ⣽ (This is taking an unexpected ⣻ (This is taking an unexpected ⢿ (This is taking an unexpected ⡿ (This is taking an unexpected ⣟ (This is taking an unexpected ⣯ (This is taking an unexpected ⣷ (This is taking an unexpected ⣾ (This is taking an unexpected ⣽ (This is taking an unexpected ⣻ (This is taking an unexpected ⢿ (This is taking an unexpected ⡿ (This is taking an unexpected ⣟ (This is taking an unexpected ⣯ (This is taking an unexpectedly long time.) ```
Contributor
|
@gspencergoog should review this PR |
zoechi
added
the
tool
gspencergoog
requested changes
Feb 26, 2019
| } | ||
| } | ||
|
|
||
| const String _kBackspaceChar = '\b'; |
Contributor
There was a problem hiding this comment.
This can be renamed _backspaceChar and moved into AnsiSpinner.
| } | ||
|
|
||
| const String _kBackspaceChar = '\b'; | ||
| const String _kClearChar = ' '; |
Contributor
There was a problem hiding this comment.
This can be renamed _clearChar and moved into AnsiSpinner.
| assert(timer != null); | ||
| assert(timer.isActive); | ||
| stdout.write('${_backspace * (spinnerIndent + 1)}'); | ||
| stdout.write('$_backspace'); |
Contributor
There was a problem hiding this comment.
This can just be:
Suggested change
| stdout.write('$_backspace'); | |
| stdout.write(_backspace); |
|
|
||
| void _clearStatus() { | ||
| stdout.write('${_backspace * _totalMessageLength}${_clear * _totalMessageLength}${_backspace * _totalMessageLength}'); | ||
| stdout.write('${_kBackspaceChar * _totalMessageLength}${_kClearChar * _totalMessageLength}${_kBackspaceChar * _totalMessageLength}'); |
Contributor
There was a problem hiding this comment.
Does this also need take into account the length of the spinner itself?
Contributor
Author
There was a problem hiding this comment.
I believe that _totalMessageLength already considered padding.
gspencergoog
approved these changes
Feb 26, 2019
Contributor
|
Thanks for fixing that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26922
Without the fix, the newly added test failed with the following error: