Repository navigation
Make RenderUiKitView reject absorbed touch events - #28666
Merged
Merged
Conversation
dnfield
reviewed
Mar 1, 2019
collinjackson
self-requested a review
March 1, 2019 01:05
amirh
force-pushed
the
uikitview_reject_absorbed
branch
from
March 1, 2019 02:50
9fdb1b0 to
c73c311
Compare
Contributor
|
This LGTM, though I suspect it would be good to get a review from someone else more familiar with the gesture system. |
goderbauer
added
the
framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a touch event that is in the bounds of a RenderUiKitView is absorbed by another render object,
the RenderUiKitView's handleEvent is not called for that object. On the platform side, the touch event hits the FlutterTouchInterceptingView which is waiting for a framework decision that never arrived on whether to reject or accept the gesture.
This change fixes the issue by having RenderUiKitView register a global PointerRoute, that is used to reject absorbed touch events.
Related Issues
#28659