Skip to content

Avoid the overhead of instantiating a generator in paintImage - #28736

Merged
jason-simmons merged 1 commit into
flutter:masterfrom
jason-simmons:sync_generator_perf
Mar 4, 2019
Merged

jason-simmons merged 1 commit into
flutter:masterfrom
jason-simmons:sync_generator_perf

Conversation

@jason-simmons

Copy link
Copy Markdown
Member

This function is called frequently with non-repeating images during many
animations

This function is called frequently with non-repeating images during many
animations
@jason-simmons
jason-simmons requested a review from Hixie March 1, 2019 19:11

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label Mar 1, 2019
@jason-simmons
jason-simmons merged commit c352738 into flutter:master Mar 4, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants