Skip to content

update CupertinoSwitch documentation - #29987

Merged
LongCatIsLooong merged 3 commits into
flutter:masterfrom
LongCatIsLooong:updateCupertinoSwitchDocumentation
Mar 27, 2019
Merged

LongCatIsLooong merged 3 commits into
flutter:masterfrom
LongCatIsLooong:updateCupertinoSwitchDocumentation

Conversation

@LongCatIsLooong

Copy link
Copy Markdown
Contributor

Description

Documented CupertinoSwitch.value that it can't be null and added an assertion value != null in the constructor.

Related Issues

#12948

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@LongCatIsLooong
LongCatIsLooong requested a review from xster March 26, 2019 17:32
@LongCatIsLooong LongCatIsLooong added p: cupertino_ui cupertino_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Mar 26, 2019
Comment thread packages/flutter/lib/src/cupertino/switch.dart
@LongCatIsLooong
LongCatIsLooong requested a review from xster March 26, 2019 20:01
@xster

xster commented Mar 26, 2019

Copy link
Copy Markdown
Member

LGTM. You can merge it when our tree is green.

@HansMuller HansMuller added the d: api docs Issues with https://api.flutter.dev/ label Mar 27, 2019
@LongCatIsLooong
LongCatIsLooong merged commit 817b959 into flutter:master Mar 27, 2019
@LongCatIsLooong
LongCatIsLooong deleted the updateCupertinoSwitchDocumentation branch March 27, 2019 17:41
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants