Repository navigation
Adds the keyboard mapping for Linux - #29993
Merged
Merged
Conversation
Specifically, the GLFW key code mapping since that's the current implementation on the flutter desktop embedding project. It can be extended to more implementations.
goderbauer
added
a: desktop
franciscojma86
marked this pull request as ready for review
March 27, 2019 01:15
gspencergoog
approved these changes
Mar 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, the GLFW key code mapping since that's the current window implementation on the flutter desktop embedding project. It can extended to more implementations. GLFW offers a limited set of key codes, and requires custom logic from the embedder to provide the right values.
X11 doesn't seem to provide different keys for left/right modifiers so the side defaults to 'any'
https://code.woboq.org/qt5/include/X11/X.h.html#_M/ShiftMask
Example of data produced:
RawKeyEventDataLinux(keyLabel: $, keyCode: 52, scanCode: 13, codePoint: 36, modifiers: 1, modifiers down: {ModifierKey.shiftModifier: KeyboardSide.any})
LogicalKeyboardKey#00024(keyId: "0x00000024", keyLabel: "$", debugName: "Key $")
PhysicalKeyboardKey#70021(usbHidUsage: "0x00070021", debugName: "Digit 4")
This is not a breaking change.