Skip to content

Rename Border.uniform() -> Border.fromSide() - #30792

Merged
tvolkert merged 2 commits into
flutter:masterfrom
tvolkert:fromSide
Apr 17, 2019
Merged

tvolkert merged 2 commits into
flutter:masterfrom
tvolkert:fromSide

Conversation

@tvolkert

@tvolkert tvolkert commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tvolkert
tvolkert requested a review from Hixie April 9, 2019 16:32
@tvolkert tvolkert mentioned this pull request Apr 9, 2019
8 of 9 tasks

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield

dnfield commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

When I read fromSide I end up wondering which side. IMO uniform is clearer.

@tvolkert

tvolkert commented Apr 9, 2019

Copy link
Copy Markdown
Contributor Author

fwiw, I can see both sides of it (truly no pun intended) and don't feel strongly either way. I like both fromSide() and uniform().

@dnfield

dnfield commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

Maybe fromUniformSide? Although that's getting back closer to where this all started. What do you think @jonahwilliams ?

@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label Apr 9, 2019
@Hixie

Hixie commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

fromBorderSide maybe?

The problem with uniform is that that means the same as all and it's not clear why you'd use one or the other from the name.

@tvolkert

tvolkert commented Apr 9, 2019

Copy link
Copy Markdown
Contributor Author

fromBorderSide is definitely unambiguous. +1 from me.

@dnfield

dnfield commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

My understanding is that const is the disambiguator here - you use this one when you want a const version and are willing to explicitly provide a borderside rather than the individual properties that .all expects. But fromBorderSide is a bit clearer at least.

@dnfield

dnfield commented Apr 10, 2019

Copy link
Copy Markdown
Contributor

LGTM

@tvolkert
tvolkert merged commit a4ab032 into flutter:master Apr 17, 2019
@tvolkert
tvolkert deleted the fromSide branch April 17, 2019 17:58
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants