Repository navigation
add --force flag to precache - #31278
Merged
Merged
Conversation
zanderso
approved these changes
Apr 18, 2019
| } | ||
| } | ||
| if (cache.isUpToDate()) { | ||
| if (cache.isUpToDate() && !argResults['force']) { |
Member
There was a problem hiding this comment.
nit: maybe easier to read flipped around:
final bool forceUpdate = argResult['force'];
if (forceUpdate || !cache.isUpToDate()) {
await cache.updateAll(requiredArtifacts);
} else {
printStatus(...);
}
Then you also don't evaluate cache.isUpToDate() when you have --force
added 2 commits
April 18, 2019 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows users to force re-downloading of artifacts (due to corruption, or tools code errors) without needing to rm -rf bin/cache.
Related Issues
None
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?