Repository navigation
Add BottomSheetTheme to enable theming color, elevation, shape of BottomSheet - #31318
Merged
Merged
Conversation
rami-a
changed the title
goderbauer
added
p: material_ui
rami-a
force-pushed
the
feature-30444-bottomsheet-shape
branch
from
April 22, 2019 16:57
825c6e5 to
da9ee6b
Compare
rami-a
changed the title
rami-a
marked this pull request as ready for review
April 23, 2019 13:26
johnsonmh
approved these changes
Apr 23, 2019
HansMuller
reviewed
Apr 30, 2019
HansMuller
left a comment
HansMuller
left a comment
Contributor
There was a problem hiding this comment.
This is a nice simple addition. Mostly just some comments about testing.
HansMuller
reviewed
Apr 30, 2019
HansMuller
left a comment
HansMuller
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good; I think one final round or simplification is possible.
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change introduces a BottomSheetTheme that allows you to theme color, elevation, and shape of BottomSheet. This can be done at the theme level and at call time of
showBottomSheetandshowModalBottomSheet. See the following image for an example (with some questionable design choices):Related Issues
Closes #26854
Closes #30444
Tests
I added the following tests:
BottomSheetitselfshowBottomSheetandshowModalBottomSheetpass through color/elevation/shape to theBottomSheetChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?