Repository navigation
Change unfocus to unfocus the entire chain, not just the primary focus - #31909
Merged
Merged
Conversation
gspencergoog
force-pushed
the
fix_scope_unfocus
branch
3 times, most recently
from
May 1, 2019 16:21
097d475 to
1165ff8
Compare
goderbauer
added
the
framework
gspencergoog
force-pushed
the
fix_scope_unfocus
branch
from
May 1, 2019 17:24
1165ff8 to
62b18bc
Compare
darrenaustin
approved these changes
May 1, 2019
darrenaustin
left a comment
darrenaustin
left a comment
Contributor
There was a problem hiding this comment.
Again, not familiar with this code, but it LGTM.
| assert(_node != null); | ||
| if (isAttached) { | ||
| if (_node.hasPrimaryFocus) { | ||
| _node.unfocus(); |
Contributor
There was a problem hiding this comment.
Minor nit, missing a space of indentation?
Contributor
Author
There was a problem hiding this comment.
Oooh, good eye. Yes, I'll fix that.
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #31614, I added an
unfocus()to FocusNodes to allow giving up of focus, but it only worked on the primary focus. This PR changes that so that it will unfocus the entire chain, not just the primary focus. Now, if you callunfocus()on aFocusNodeorFocusScopeNode, and theirhasFocusreturns true, then after callingunfocus(), it will return false. Before this PR, it would only do that ifhasPrimaryFocuswas also true.This also fixes a bug in the way
setFirstFocuswas implemented, making it conform more to the behavior of the previous implementation. It has simplified logic inreparent, and in when it requests focus for scope nodes that have hadsetFirstFocuscalled on them.Related Issues
Fixes #31784
Fixes #7247
Fixes #31827
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?