Repository navigation
cherry-pick: fix edge swiping and dropping back at starting point (#31623) - #31967
Merged
Merged
Conversation
kf6gpe
reviewed
May 2, 2019
kf6gpe
left a comment
kf6gpe
left a comment
Contributor
There was a problem hiding this comment.
LGTM code wise. Not sure what's up with the tests, though.
Contributor
|
There is a bug in our version verification logic, it can't handle hotfixes. If all other tests passed it should be good to go |
Contributor
|
(Only the verification logic for this test, not for the tool itself) |
kf6gpe
approved these changes
May 2, 2019
kf6gpe
left a comment
kf6gpe
left a comment
Contributor
There was a problem hiding this comment.
Based on @jonahwilliams comment, approving. Thank you!!
Member
Author
|
All the test failures seem related to the version and flutter-build on master is irrelevant. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick fix for issue where a back swipe dropped at the starting point breaks future back swipes.