Skip to content

Rollback caret change for Android - #32043

Merged
GaryQian merged 1 commit into
flutter:masterfrom
GaryQian:caretrollback
May 3, 2019
Merged

GaryQian merged 1 commit into
flutter:masterfrom
GaryQian:caretrollback

Conversation

@GaryQian

@GaryQian GaryQian commented May 3, 2019

Copy link
Copy Markdown
Contributor

Rolls back what originally seemed like a trivial change, but turned out not to be.

The positioning of the caret on placeholder text is incorrect.

Original PR: #31687

@GaryQian

GaryQian commented May 3, 2019

Copy link
Copy Markdown
Contributor Author

This change is the non-ios portion of the #31687 PR extracted and reverted.

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GaryQian
GaryQian merged commit 3bd1737 into flutter:master May 3, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants