Skip to content

Fix CupertinoSliverRefreshControl onRefresh callback - #32086

Merged
LongCatIsLooong merged 3 commits into
flutter:masterfrom
LongCatIsLooong:catch-onRefresh
May 4, 2019
Merged

LongCatIsLooong merged 3 commits into
flutter:masterfrom
LongCatIsLooong:catch-onRefresh

Conversation

@LongCatIsLooong

@LongCatIsLooong LongCatIsLooong commented May 4, 2019 •

Copy link
Copy Markdown
Contributor

Description

Replace CupertinoSliverRefreshControl.onRefresh's then callback with whenCompleted callback, so when onRefresh completes with error the sliver refresh control retracts like when it completes with value.

Related Issues

Fixes #31382

Tests

I added the following tests:

  • refreshing task keeps the sliver expanded forever until completes with error

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@LongCatIsLooong LongCatIsLooong added framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages labels May 4, 2019
@LongCatIsLooong
LongCatIsLooong requested a review from xster May 4, 2019 17:22

@xster xster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/flutter/lib/src/cupertino/refresh.dart Outdated
Comment thread packages/flutter/test/cupertino/refresh_test.dart Outdated
Comment thread packages/flutter/test/cupertino/refresh_test.dart
@LongCatIsLooong
LongCatIsLooong merged commit 8800153 into flutter:master May 4, 2019
@LongCatIsLooong
LongCatIsLooong deleted the catch-onRefresh branch May 4, 2019 22:54
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CupertinoSliverRefreshControl hangs if onRefresh completes with error

3 participants