Repository navigation
Add onBytesReceived callback to consolidateHttpClientResponseBytes() - #32853
Merged
Merged
Conversation
8 of 9 tasks
This will allow us to plumb the chunks in a chunked response up to the higher levels of the framework to notify interested parties of network loading progress. #32374
Contributor
|
cc @goderbauer |
8 of 9 tasks
goderbauer
approved these changes
May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will allow us to plumb the byte chunks in a chunked
network response up to the higher levels of the framework
to notify interested parties of network loading progress.
Related Issues
#32374
Tests
I added the following tests:
onBytesReceivedcallback is invoked correctly.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?