Skip to content

WIP: Context menu - #33685

Closed
dkwingsmt wants to merge 54 commits into
flutter:masterfrom
dkwingsmt:context-menu
Closed

dkwingsmt wants to merge 54 commits into
flutter:masterfrom
dkwingsmt:context-menu

Conversation

@dkwingsmt

Copy link
Copy Markdown
Contributor

PR status

This demo has full features, but API design remains discussion.

Content and discussion: #30976

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

dkwingsmt and others added 30 commits April 15, 2019 11:07
@dkwingsmt dkwingsmt mentioned this pull request May 31, 2019
@goderbauer goderbauer added a: desktop Running on desktop p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels May 31, 2019
@dkwingsmt

Copy link
Copy Markdown
Contributor Author

Close for now. Need better design

@dkwingsmt dkwingsmt closed this Jun 17, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: desktop Running on desktop framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants