Repository navigation
Rearrange scheduling library - #3388
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
The new version of the comment seems to run on a little. Maybe:
The Scheduler runs frames at system-controlled intervals and it runs tasks during the time between frames. Tasks are run in priority order.
Contributor
Author
There was a problem hiding this comment.
replaced the whole paragraph with a bulletted list.
Contributor
|
LGTM |
To be more consistent with other parts of the platform: * put the binding in a binding.dart file. * rearrange some members of the Scheduler class to be more close to execution order. * factor out Priority class into its own file. * add more dart docs.
Contributor
Author
|
made requested changes; will land when travis goes green unless i hear otherwise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be more consistent with other parts of the platform:
execution order.