Skip to content

Revert engine back to afb9d510c3bb0f1b97980434b41200a2d3491697 - #33982

Merged
zanderso merged 1 commit into
flutter:masterfrom
zanderso:revert-engine-roll
Jun 6, 2019
Merged

zanderso merged 1 commit into
flutter:masterfrom
zanderso:revert-engine-roll

Conversation

@zanderso

@zanderso zanderso commented Jun 6, 2019

Copy link
Copy Markdown
Member

This reverts two engine rolls:

c84767c
881cdfd

For consistent bot failures in the android_views integration test.

Looks related: flutter-team-archive/engine@5ea125e @matthew-carroll @amirh

@zanderso
zanderso requested a review from tvolkert June 6, 2019 15:37
@zanderso

zanderso commented Jun 6, 2019

Copy link
Copy Markdown
Member Author

@bparrishMines

Revert "Add currentSystemFrameTimeStamp to SchedulerBinding (#33886)"

This reverts commit 61b83d3.
@zanderso

zanderso commented Jun 6, 2019

Copy link
Copy Markdown
Member Author

Also reverting 61b83d3 @goderbauer

@goderbauer

Copy link
Copy Markdown
Member

Why is 61b83d3 getting reverted?

@zanderso

zanderso commented Jun 6, 2019

Copy link
Copy Markdown
Member Author

@goderbauer There were failures related to that change in the presubmit checks for the engine revert by itself.

@goderbauer

Copy link
Copy Markdown
Member

Can you link to the failure so I can debug that for re-landing?

@zanderso

zanderso commented Jun 6, 2019 •

Copy link
Copy Markdown
Member Author

https://api.cirrus-ci.com/v1/task/6642212578787328/logs/test.log

00:19 +100 -1: /tmp/flutter sdk/packages/flutter/test/scheduler/scheduler_test.dart: currentSystemFrameTimeStamp is the raw timestamp [E]                                                              
  Expected: Duration:<0:00:00.000000>
    Actual: Duration:<-5:07:02.107324>
  
  package:test_api                     expect
  scheduler/scheduler_test.dart 152:5  main.<fn>

@zanderso
zanderso merged commit 366dcb1 into flutter:master Jun 6, 2019
@zanderso
zanderso deleted the revert-engine-roll branch June 6, 2019 16:50
@matthew-carroll

Copy link
Copy Markdown
Contributor

@zanderso do you know what I can do to repro whatever the problems were with flutter-team-archive/engine@5ea125e ? I ran an app locally before putting up the PR, and the PR checks were green...

@amirh

amirh commented Jun 6, 2019

Copy link
Copy Markdown
Contributor

@matthew-carroll run the android_views driver test

@zanderso

zanderso commented Jun 6, 2019

Copy link
Copy Markdown
Member Author

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants