Repository navigation
Listen to ExtensionEvent instead of TimelineEvent - #37900
Merged
Merged
Conversation
TimelineEvents may not be sent if there aren't enough to form a group. Hence we should always use ExtensionEvent as the trigger.
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
framework
Contributor
Author
|
@rmacnak-google : I think that we may forget to remove and recompile the flutter_tools on Friday. The ExtensionEvent works as expected today... |
Codecov Report
@@ Coverage Diff @@
## master #37900 +/- ##
==========================================
- Coverage 56.02% 55.91% -0.12%
==========================================
Files 193 193
Lines 18164 18170 +6
==========================================
- Hits 10177 10160 -17
- Misses 7987 8010 +23
Continue to review full report at Codecov.
|
rmacnak-google
approved these changes
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimelineEvents may not be sent if there aren't enough to form a group.
Hence we should always use ExtensionEvent as the trigger.
See also #37503