Skip to content

Fix text scale factor for non-content components of Cupertino scaffolds - #38593

Merged
LongCatIsLooong merged 2 commits into
flutter:masterfrom
LongCatIsLooong:fixed-scaffold-non-content-textScaleFactor
Aug 16, 2019
Merged

LongCatIsLooong merged 2 commits into
flutter:masterfrom
LongCatIsLooong:fixed-scaffold-non-content-textScaleFactor

Conversation

@LongCatIsLooong

@LongCatIsLooong LongCatIsLooong commented Aug 15, 2019 •

Copy link
Copy Markdown
Contributor

Description

Fixes the text scale factor to 1.0 for navigationBar(sliver and non sliver) and tabBar.

Related Issues

Fixes #35199

Tests

I added the following tests:

  • textScaleFactor is set to 1.0

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Aug 15, 2019
@LongCatIsLooong
LongCatIsLooong force-pushed the fixed-scaffold-non-content-textScaleFactor branch from 483fdeb to 7dbbf5a Compare August 15, 2019 00:34
@LongCatIsLooong LongCatIsLooong added the a: fidelity Matching the OEM platforms better label Aug 15, 2019

@miguelpruivo miguelpruivo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LongCatIsLooong
LongCatIsLooong merged commit 0ba8c2c into flutter:master Aug 16, 2019
@LongCatIsLooong
LongCatIsLooong deleted the fixed-scaffold-non-content-textScaleFactor branch August 16, 2019 03:02
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: fidelity Matching the OEM platforms better framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cupertino NavBar default Close text shouldn't scale with the font

5 participants