Repository navigation
[flutter_tools] Add a timeout to another showBuildSettings command - #39579
Merged
Merged
Conversation
zanderso
added
tool
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Codecov Report
@@ Coverage Diff @@
## master #39579 +/- ##
==========================================
+ Coverage 57.33% 58.35% +1.02%
==========================================
Files 194 194
Lines 18691 18706 +15
==========================================
+ Hits 10716 10916 +200
+ Misses 7975 7790 -185
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I missed a
-showBuildSettingscommand in my previous PR: #39280Related Issues
#35988
Tests
I added the following tests:
Added a couple of tests to devices_test.dart that exercise
IosDevice.startApp()in the case where the app is not pre-built, which triggers a build, which calls xcode with-showBuildSettings.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?