Skip to content

CupertinoButton & Bottom tab bar dark mode - #39765

Merged
LongCatIsLooong merged 5 commits into
flutter:masterfrom
LongCatIsLooong:dark-mode-b
Sep 5, 2019
Merged

CupertinoButton & Bottom tab bar dark mode#39765
LongCatIsLooong merged 5 commits into
flutter:masterfrom
LongCatIsLooong:dark-mode-b

Conversation

@LongCatIsLooong

@LongCatIsLooong LongCatIsLooong commented Sep 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Cupertino components with initial B.

Related Issues

#35541

Tests

I added the following tests:

  • bottom_tab_bar: Active and inactive colors dark mode
  • button: Can specify dynamic colors

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Sep 3, 2019
justinmc
justinmc approved these changes Sep 3, 2019
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a quick formatting thing.

Comment thread packages/flutter/lib/src/cupertino/bottom_tab_bar.dart Outdated

BorderSide resolveBorderSide(BorderSide side) {
if (side == BorderSide.none)
return side;

@justinmc justinmc Sep 3, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent

@LongCatIsLooong LongCatIsLooong Sep 3, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah my editor at it again. Fixed

@LongCatIsLooong
LongCatIsLooong merged commit 443892b into flutter:master Sep 5, 2019
@LongCatIsLooong
LongCatIsLooong deleted the dark-mode-b branch September 5, 2019 17:06
@justinmc justinmc mentioned this pull request Sep 6, 2019
Closed
6 tasks done
@HansMuller HansMuller mentioned this pull request Oct 18, 2019
Closed
17 of 18 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@justinmc justinmc justinmc approved these changes
@HansMuller HansMuller Awaiting requested review from HansMuller
@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LongCatIsLooong @justinmc @googlebot @fluttergithubbot