Skip to content

Fixed DropdownButton behavior, when keyboard is visible - #41574

Closed
sarbagyastha wants to merge 1 commit into
flutter:masterfrom
sarbagyastha:master
Closed

Fixed DropdownButton behavior, when keyboard is visible#41574
sarbagyastha wants to merge 1 commit into
flutter:masterfrom
sarbagyastha:master

Conversation

@sarbagyastha

@sarbagyastha sarbagyastha commented Sep 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR addresses the issue with DropdownButton where tapping on it with an open keyboard would cause an inappropriate behavior as shown below in before(s):

Before ( in stable channel ) After ( in stable channel )
before_one after_one
Need to tap twice Fixed Behavior in stable
Before ( after #40166 ) After ( after #40166 )
before_two after_two
Current behaviour in master channel Fixed Behavior in master

Related Issues

#22075
#41881

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Sep 29, 2019
This was referenced Oct 2, 2019
Merged
Closed
@HansMuller

HansMuller commented Oct 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

CC @gspencergoog (who as also been working on this problem), see #41881

@dalewking

dalewking commented Oct 10, 2019

Copy link
Copy Markdown

This change didn't work for me, because there is not just one call to didChangeMetrics when this happens. With a breakpoint I see it called 3 times and your fix only takes care of the first time.

Luckily in our app we don't support orientation changes so I was able to just comment out didChangeMetrics and got it to work. That of course, is not a solution when you need to support orientation changes.

@sarbagyastha

sarbagyastha commented Oct 14, 2019

Copy link
Copy Markdown
Contributor Author

#42482

@khun-ye

khun-ye commented Oct 22, 2019

Copy link
Copy Markdown

I have upgrading my flutter package from the latest stable channel, but the issue of Drop DownButton behavior, when keyboard is visible is not fixed. how can I do to solve this. any suggestion.

@dalewking

dalewking commented Oct 22, 2019

Copy link
Copy Markdown

Sincerely doubt it has made it to the stable channel yet. To see the fix at the moment, probably have to be on master

@gspencergoog

gspencergoog commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

Yes, @yetunnaing18121996 , @dalewking is correct. For right now, the fix is only available on the master channel.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sarbagyastha @HansMuller @dalewking @khun-ye @gspencergoog @googlebot @fluttergithubbot