Skip to content

Wire selectedItemBuilder through DropdownButtonFormField - #44160

Merged
shihaohong merged 1 commit into
flutter:masterfrom
shihaohong:dropdown-formfield-item-builder
Nov 5, 2019
Merged

shihaohong merged 1 commit into
flutter:masterfrom
shihaohong:dropdown-formfield-item-builder

Conversation

@shihaohong

Copy link
Copy Markdown
Contributor

Description

Implements selectedItemBuilder for DropdownButtonFormField.

Related Issues

Fixes #42481

Tests

I added the following tests:

  • A test to ensure that custom items are being displayed.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@shihaohong shihaohong added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Nov 5, 2019
@shihaohong
shihaohong requested a review from HansMuller November 5, 2019 05:36

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shihaohong
shihaohong merged commit 1663fde into flutter:master Nov 5, 2019
@shihaohong
shihaohong deleted the dropdown-formfield-item-builder branch November 5, 2019 20:32
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wire DropdownButton.selectedItemBuilder through DropdownFormField

3 participants