Skip to content

Spell check of Flutter docs - #45200

Merged
gspencergoog merged 3 commits into
flutter:masterfrom
gspencergoog:spell_check
Nov 22, 2019
Merged

Spell check of Flutter docs#45200
gspencergoog merged 3 commits into
flutter:masterfrom
gspencergoog:spell_check

Conversation

@gspencergoog

@gspencergoog gspencergoog commented Nov 19, 2019

Copy link
Copy Markdown
Contributor

No code changes, just comments: I spell-checked all the comments in the repo.

@fluttergithubbot fluttergithubbot added a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 19, 2019
@gspencergoog gspencergoog added d: api docs Issues with https://api.flutter.dev/ documentation and removed a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests cla: yes d: examples Sample code and demos p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 19, 2019
natebosch
natebosch reviewed Nov 19, 2019
View reviewed changes

@natebosch natebosch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this spell checker may be too zealous on compound words...

Comment thread dev/bots/test.dart Outdated
Comment thread packages/flutter/lib/src/painting/binding.dart Outdated
Comment thread packages/flutter/lib/src/painting/text_painter.dart Outdated
Comment thread packages/flutter/lib/src/painting/text_painter.dart Outdated
Comment thread packages/flutter/lib/src/rendering/sliver_multi_box_adaptor.dart Outdated
Comment thread packages/flutter/lib/src/services/text_input.dart Outdated
@gspencergoog

gspencergoog commented Nov 20, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hmm. I much prefer all of the hyphenated ones, but maybe that just makes me uncommon (un-common? :-) ). The non-hyphenated versions all look like made up words to me.

I reverted all the hyphenations I added, and all other hyphenations of these words in all the comments, so that we're at least consistent.

I kept plain text because it feels more descriptive and less a term of art (and it's nearly as common).

@gspencergoog gspencergoog changed the title Spell check of flutter docs Spell check of Flutter docs Nov 20, 2019
@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos p: cupertino_ui cupertino_ui package in flutter/packages labels Nov 20, 2019
@gspencergoog gspencergoog removed a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 20, 2019
Hixie
Hixie reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/flutter/lib/src/material/slider_theme.dart Outdated
Hixie
Hixie reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/flutter/lib/src/material/slider_theme.dart Outdated
Hixie
Hixie reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/flutter_goldens/lib/flutter_goldens.dart Outdated
Hixie
Hixie reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/flutter_tools/lib/src/asset.dart Outdated
Hixie
Hixie reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/flutter_tools/lib/src/build_runner/web_fs.dart Outdated
Hixie
Hixie reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/flutter_tools/lib/src/build_system/source.dart Outdated
Hixie
Hixie reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/flutter_tools/lib/src/dart/package_map.dart Outdated
Hixie
Hixie reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/flutter_tools/lib/src/devfs.dart Outdated
Hixie
Hixie reviewed Nov 20, 2019
View reviewed changes
Comment thread packages/flutter_tools/lib/src/device.dart Outdated
@Hixie

Hixie commented Nov 20, 2019

Copy link
Copy Markdown
Contributor

LGTM

@gspencergoog
gspencergoog force-pushed the spell_check branch 2 times, most recently from 67e38ee to 773557a Compare November 21, 2019 16:44
darielopper
darielopper reviewed Nov 22, 2019
View reviewed changes
Comment thread dev/devicelab/lib/framework/framework.dart Outdated
darielopper
darielopper reviewed Nov 22, 2019
View reviewed changes
Comment thread packages/flutter_tools/lib/src/protocol_discovery.dart Outdated
darielopper
darielopper suggested changes Nov 22, 2019
View reviewed changes
Comment thread packages/flutter_tools/lib/src/test/flutter_platform.dart Outdated
@gspencergoog gspencergoog mentioned this pull request Nov 22, 2019
Merged
8 of 9 tasks
@gspencergoog
gspencergoog merged commit a60bf8e into flutter:master Nov 22, 2019
@gspencergoog
gspencergoog deleted the spell_check branch January 16, 2020 22:12
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Hixie left review comments
@natebosch natebosch natebosch left review comments
+2 more reviewers
@jonahwilliams jonahwilliams jonahwilliams left review comments
@darielopper darielopper darielopper requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gspencergoog @Hixie @natebosch @jonahwilliams @darielopper @googlebot @fluttergithubbot