Skip to content

Add visualDensity to checkbox, radio, icon button, and chip. - #46091

Merged
gspencergoog merged 5 commits into
flutter:masterfrom
gspencergoog:checkbox_density
Dec 6, 2019
Merged

Add visualDensity to checkbox, radio, icon button, and chip.#46091
gspencergoog merged 5 commits into
flutter:masterfrom
gspencergoog:checkbox_density

Conversation

@gspencergoog

@gspencergoog gspencergoog commented Dec 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This adds a visualDensity attribute to checkbox, radio, icon button, and chip.

Tests

  • added tests for all components.

Breaking Change

  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Dec 4, 2019
@gspencergoog
gspencergoog force-pushed the checkbox_density branch 2 times, most recently from fdba02e to 2120ee3 Compare December 4, 2019 17:14
@shihaohong
shihaohong self-requested a review December 4, 2019 17:50
shihaohong
shihaohong reviewed Dec 4, 2019
View reviewed changes
Comment thread packages/flutter/test/material/icon_button_test.dart Outdated
Comment thread packages/flutter/test/material/icon_button_test.dart Outdated
Comment thread packages/flutter/lib/src/material/chip.dart Outdated
Comment thread packages/flutter/test/material/chip_test.dart Outdated
Comment thread packages/flutter/test/material/chip_test.dart Outdated
Comment thread dev/manual_tests/lib/density.dart Outdated
Comment thread dev/manual_tests/lib/density.dart Outdated
Comment thread dev/manual_tests/lib/density.dart Outdated
Comment thread dev/manual_tests/lib/density.dart Outdated
Comment thread dev/manual_tests/lib/density.dart Outdated
shihaohong
shihaohong reviewed Dec 4, 2019
View reviewed changes
Comment thread packages/flutter/test/material/chip_test.dart Outdated
shihaohong
shihaohong reviewed Dec 4, 2019
View reviewed changes
Comment thread packages/flutter/test/material/icon_button_test.dart Outdated
@gspencergoog
gspencergoog force-pushed the checkbox_density branch 2 times, most recently from 7454765 to 52f3bf9 Compare December 5, 2019 01:26
shihaohong
shihaohong reviewed Dec 5, 2019
View reviewed changes
Comment thread packages/flutter/test/material/flat_button_test.dart Outdated
@gspencergoog
gspencergoog force-pushed the checkbox_density branch 2 times, most recently from ef5da13 to f6f13a4 Compare December 5, 2019 17:26
shihaohong
shihaohong reviewed Dec 5, 2019
View reviewed changes
Comment thread dev/manual_tests/lib/density.dart Outdated
shihaohong
shihaohong reviewed Dec 5, 2019
View reviewed changes
Comment thread dev/manual_tests/lib/density.dart Outdated
shihaohong
shihaohong approved these changes Dec 5, 2019
View reviewed changes

@shihaohong shihaohong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog
gspencergoog merged commit bc7ed36 into flutter:master Dec 6, 2019
@gspencergoog gspencergoog mentioned this pull request Dec 18, 2019
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@shihaohong shihaohong shihaohong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gspencergoog @shihaohong @googlebot @fluttergithubbot