Skip to content

Name the docker_builder shard - #46103

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
tvolkert:cirrus2
Dec 5, 2019
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
tvolkert:cirrus2

Conversation

@tvolkert

@tvolkert tvolkert commented Dec 4, 2019

Copy link
Copy Markdown
Contributor

Currently, the docker_builder shard on Cirrus has no name, so it show up as "main"

@tvolkert

tvolkert commented Dec 4, 2019

Copy link
Copy Markdown
Contributor Author

@fkorotkov

@fkorotkov

fkorotkov commented Dec 4, 2019 •

Copy link
Copy Markdown
Contributor

Yeah, that's the defat name. 🤷‍♂️ You can add name filed as well though.

@tvolkert

tvolkert commented Dec 4, 2019

Copy link
Copy Markdown
Contributor Author

Is this patch correct, then?

@fkorotkov

Copy link
Copy Markdown
Contributor

Correct, you can even make it like "Docker Build"

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@christopherfujino christopherfujino changed the title Name the docker_builer shard Name the docker_builder shard Dec 4, 2019
@tvolkert

tvolkert commented Dec 5, 2019

Copy link
Copy Markdown
Contributor Author

@fkorotkov it looks like the deploy_gallery-macos shard has been pending for over 2 1/2 hours. Is that normal?

@christopherfujino

Copy link
Copy Markdown
Contributor

@tvolkert do you want to just comment out this phase with a TODO to be resolved by this issue #45351? This phase will only run on releases anyway, and we know it's currently failing.

@tvolkert

tvolkert commented Dec 5, 2019

Copy link
Copy Markdown
Contributor Author

Regardless of if it's failing, I'd like it to be named something obvious. "main" was confusing and had me looking in the Cirrus config file for a task named "main"

@fluttergithubbot
fluttergithubbot merged commit 6d848eb into flutter:master Dec 5, 2019
@tvolkert
tvolkert deleted the cirrus2 branch December 5, 2019 20:16
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants