Skip to content

Allow plugins that don't support the Android platform - #46282

Merged
blasten merged 1 commit into
flutter:masterfrom
blasten:plugin_without_android_platform
Dec 9, 2019
Merged

blasten merged 1 commit into
flutter:masterfrom
blasten:plugin_without_android_platform

Conversation

@blasten

@blasten blasten commented Dec 7, 2019

Copy link
Copy Markdown

Description

A plugin may not support the Android platform. In this case, skip that plugin when building the APK.

Tests

I added the following tests: integration test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 7, 2019
@blasten
blasten requested a review from amirh December 7, 2019 02:24
@blasten
blasten force-pushed the plugin_without_android_platform branch from 59ade41 to 7f6469c Compare December 7, 2019 02:43

@amirh amirh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten
blasten force-pushed the plugin_without_android_platform branch 2 times, most recently from ece2ee0 to 5d22986 Compare December 7, 2019 04:04
@blasten
blasten force-pushed the plugin_without_android_platform branch from 5d22986 to 285870b Compare December 7, 2019 04:46
@blasten
blasten merged commit f264d6c into flutter:master Dec 9, 2019
@blasten
blasten deleted the plugin_without_android_platform branch December 9, 2019 04:04
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants