Skip to content

Test hot reload targeting a Fuchsia device - #48472

Merged
fluttergithubbot merged 5 commits into
flutter:masterfrom
blasten:fuchsia_attach_test
Jan 10, 2020
Merged

Test hot reload targeting a Fuchsia device#48472
fluttergithubbot merged 5 commits into
flutter:masterfrom
blasten:fuchsia_attach_test

Conversation

@blasten

@blasten blasten commented Jan 9, 2020

Copy link
Copy Markdown

This tests hot reload on a Fuchsia device.

I still need to filter out old logs from the FuchsiaDevice logger since it currently doesn't filter old logs. This doesn't affect the outcome of this test though.

@fluttergithubbot fluttergithubbot added d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 9, 2020
@blasten blasten added platform-fuchsia Fuchsia code specifically and removed cla: yes labels Jan 9, 2020
@flutter flutter deleted a comment from fluttergithubbot Jan 9, 2020
zanderso
zanderso reviewed Jan 9, 2020
View reviewed changes

@zanderso zanderso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Comment thread dev/devicelab/bin/tasks/flutter_attach_test_fuchsia.dart Outdated
Comment thread packages/flutter_tools/lib/src/fuchsia/fuchsia_sdk.dart Outdated
@blasten
blasten force-pushed the fuchsia_attach_test branch from 7ff03e6 to f53fdb9 Compare January 9, 2020 21:15
@blasten blasten mentioned this pull request Jan 9, 2020
Closed
@blasten
blasten force-pushed the fuchsia_attach_test branch from f53fdb9 to c8f86bc Compare January 9, 2020 21:46
@blasten
blasten force-pushed the fuchsia_attach_test branch from c8f86bc to c96d143 Compare January 9, 2020 21:51
@blasten
blasten requested a review from zanderso January 9, 2020 21:51
@blasten

blasten commented Jan 9, 2020

Copy link
Copy Markdown
Author

@zanderso PTAL

zanderso
zanderso reviewed Jan 9, 2020
View reviewed changes
Comment thread dev/devicelab/bin/tasks/flutter_attach_test_fuchsia.dart Outdated
Comment thread packages/flutter_tools/lib/src/fuchsia/fuchsia_device.dart Outdated
Comment thread packages/flutter_tools/lib/src/fuchsia/fuchsia_device.dart Outdated
Comment thread packages/flutter_tools/lib/src/fuchsia/fuchsia_sdk.dart Outdated
@blasten
blasten requested a review from zanderso January 9, 2020 22:23
zanderso
zanderso approved these changes Jan 9, 2020
View reviewed changes

@zanderso zanderso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ fix of analyzer message in attach.dart

@fluttergithubbot
fluttergithubbot merged commit fca5917 into flutter:master Jan 10, 2020
@jmagman jmagman mentioned this pull request Jul 21, 2021
Closed
21 of 22 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes
@iskakaushik iskakaushik Awaiting requested review from iskakaushik

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-fuchsia Fuchsia code specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blasten @zanderso @jmagman @googlebot @fluttergithubbot