Repository navigation
fix missing spaces in adjacent strings - #49159
Merged
fluttergithubbot merged 2 commits intoJan 22, 2020
Merged
Conversation
fluttergithubbot
added
p: cupertino_ui
a14n
force-pushed
the
missing-spaces-adjacent-strings
branch
4 times, most recently
from
January 20, 2020 14:11
bc2860a to
b7764b3
Compare
a14n
force-pushed
the
missing-spaces-adjacent-strings
branch
3 times, most recently
from
January 21, 2020 09:19
6729b1c to
5396831
Compare
a14n
force-pushed
the
missing-spaces-adjacent-strings
branch
from
January 21, 2020 09:36
5396831 to
88d6227
Compare
Hixie
reviewed
Jan 22, 2020
| if (!mounted) { | ||
| throw FlutterError( | ||
| 'AutomaticKeepAlive handle triggered after AutomaticKeepAlive was disposed.' | ||
| 'AutomaticKeepAlive handle triggered after AutomaticKeepAlive was disposed. ' |
Contributor
There was a problem hiding this comment.
this should actually be a newline (see docs for FlutterError constructor)
Contributor
|
This is fantastic, thanks @a14n! |
This was referenced Jan 22, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing space in adjacent strings
Related Issues
Fixes #48090
Tests
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.