Repository navigation
Added backgroundImage to CircleAvatar. - #4971
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
This should probably be an ImageProvider rather than an entire background image. The other properties (e.g., alignment, fit, and repeating) don't make sense for clients to control.
dragostis
force-pushed
the
circle-avatar-background-image
branch
from
July 20, 2016 16:23
131b836 to
710cb0f
Compare
dragostis
force-pushed
the
circle-avatar-background-image
branch
from
July 20, 2016 16:52
710cb0f to
83f3724
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to have an efficient way to display clipped avatars,
backgroundImage was added inside of the container's BoxDecoration.
Fixes #4964.