Skip to content

Remove dead code IMobileDevice.isWorking - #50084

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:dead-isworking
Feb 4, 2020
Merged

jmagman merged 1 commit into
flutter:masterfrom
jmagman:dead-isworking

Conversation

@jmagman

@jmagman jmagman commented Feb 4, 2020

Copy link
Copy Markdown
Member

Description

IMobileDevice.isWorking is dead code and was only referenced in a unit test.
Removing the dead getter also made Artifacts.idevicename dead, too. Remove it.

Tests

Deleted isWorking tests. Nothing was testing idevicename.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 4, 2020
@jmagman jmagman self-assigned this Feb 4, 2020

@zanderso zanderso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jmagman
jmagman merged commit d00a39c into flutter:master Feb 4, 2020
@jmagman
jmagman deleted the dead-isworking branch February 4, 2020 22:18
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants