Repository navigation
[flutter_tools] Reland flutter assemble for iOS - #50229
Merged
Merged
Conversation
added 9 commits
January 30, 2020 11:23
fluttergithubbot
added
the
tool
Contributor
Author
|
I also need to update the expected analytics for the module_test_ios |
jmagman
approved these changes
Feb 6, 2020
| final RunResult iphoneResult = await createStubAppFramework( | ||
| iphoneFile, | ||
| SdkType.iPhone, | ||
| // Only include 32bit if it is contained in the active arches. |
Contributor
Author
|
Since the last commit passed, and these checks are obviously flakes I'm going to submit anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates xcode_backend.sh to use (mostly) assemble APIs. This almost completes the migration, though I still need to move the asset unpack step - this is slightly more complicated due to the module format.
Should have no new external behavior, but does allow us to more easily wire up new features like font-subset, dart-defines, and obfuscation (which was never implemented for iOS?)
FYI @dnfield
Fixes #32925
Reland: Makes the Universal framework depend on kernel. Due to the behavior of the codegen integration, running them at the same time causes parts of .dart_tool to be deleted and recreated.
Reland: Don't specify an armv7 (32 bit) arch unless it is listed as active arches, since this isn't supported on newer deployment targets