Skip to content

remove isinitialroute from RouteSettings - #51435

Merged
chunhtai merged 1 commit into
flutter:masterfrom
chunhtai:nav-refactor-remove
Feb 27, 2020
Merged

chunhtai merged 1 commit into
flutter:masterfrom
chunhtai:nav-refactor-remove

Conversation

@chunhtai

@chunhtai chunhtai commented Feb 25, 2020 •

Copy link
Copy Markdown
Contributor

Description

Remove the deprecated isinitialroute, this is the prerequisite for landing page api
The migration guide https://flutter.dev/docs/release/breaking-changes/route-navigator-refactoring

Related Issues

#45938

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@chunhtai chunhtai added framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes labels Feb 25, 2020
@fluttergithubbot

Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer

Copy link
Copy Markdown
Member

Did we write a migration guide when we deprecated this explaining to people what to do instead?

@chunhtai

Copy link
Copy Markdown
Contributor Author

Did we write a migration guide when we deprecated this explaining to people what to do instead?

yes the migration guide was already written during the deprecation https://flutter.dev/docs/release/breaking-changes/route-navigator-refactoring

@goderbauer

Copy link
Copy Markdown
Member

Can you link it in the PR description so people, who determined that this PR broke them, can easily find it? Thanks.

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slightfoot

Copy link
Copy Markdown
Member

@goderbauer @chunhtai Please see my comment on the last issue about this.
#44930 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: API break Backwards-incompatible API changes framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants