Repository navigation
remove isinitialroute from RouteSettings - #51435
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Did we write a migration guide when we deprecated this explaining to people what to do instead? |
yes the migration guide was already written during the deprecation https://flutter.dev/docs/release/breaking-changes/route-navigator-refactoring |
|
Can you link it in the PR description so people, who determined that this PR broke them, can easily find it? Thanks. |
|
@goderbauer @chunhtai Please see my comment on the last issue about this. |
Description
Remove the deprecated isinitialroute, this is the prerequisite for landing page api
The migration guide https://flutter.dev/docs/release/breaking-changes/route-navigator-refactoring
Related Issues
#45938
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.