Skip to content

[flutter_tools] remove globals from plist parser and update tests - #51444

Merged
jonahwilliams merged 5 commits into
flutter:masterfrom
jonahwilliams:more_Test_cleanups_1234
Feb 27, 2020
Merged

jonahwilliams merged 5 commits into
flutter:masterfrom
jonahwilliams:more_Test_cleanups_1234

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Description

Towards simpler tool testing

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Feb 26, 2020
@jonahwilliams
jonahwilliams marked this pull request as ready for review February 26, 2020 01:31

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


/// The global Stdio wrapper.
Stdio get stdio => context.get<Stdio>() ?? const Stdio();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jonahwilliams
jonahwilliams merged commit 80619f1 into flutter:master Feb 27, 2020
@jonahwilliams
jonahwilliams deleted the more_Test_cleanups_1234 branch February 27, 2020 02:31
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants