Skip to content

Don't leave tabs hanging in the middle - #5153

Merged
HansMuller merged 2 commits into
flutter:masterfrom
HansMuller:tabs_stuck_in_the_middle
Jul 29, 2016
Merged

HansMuller merged 2 commits into
flutter:masterfrom
HansMuller:tabs_stuck_in_the_middle

Conversation

@HansMuller

@HansMuller HansMuller commented Jul 29, 2016 •

Copy link
Copy Markdown
Contributor

If the conclusion of a short press-drag-release gesture is a fling in the opposite direction, and there aren't any other tabs in that direction, then the fling() logic should settleScrollOffset(). In other words if you start dragging in one direction and then fling in the other, so that the selected tab shouldn't change, just return the scrollOffset to where it was.

Fixes #5095

@HansMuller HansMuller changed the title Dont leave tabs hanging in the middle Don't leave tabs hanging in the middle Jul 29, 2016
@abarth

abarth commented Jul 29, 2016

Copy link
Copy Markdown
Contributor

LGTM

@HansMuller
HansMuller merged commit 566cacb into flutter:master Jul 29, 2016
@HansMuller
HansMuller deleted the tabs_stuck_in_the_middle branch July 29, 2016 21:16
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gallery, Tabs: Can leave tab bodies in an in-between state

2 participants