Skip to content

Revert "Refactoring Gold to enable both Luci & Cirrus support" - #52670

Merged
Piinks merged 1 commit into
masterfrom
revert-49815-luciAuth
Mar 16, 2020
Merged

Piinks merged 1 commit into
masterfrom
revert-49815-luciAuth

Conversation

@Piinks

@Piinks Piinks commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

Reverts #49815

This is breaking engine tests when they run framework tests on luci.

@fluttergithubbot fluttergithubbot added p: cupertino_ui cupertino_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Mar 16, 2020
@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite submit-queue has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks

Piinks commented Mar 16, 2020

Copy link
Copy Markdown
Contributor Author

I have checked Cirrus and it appear that all of the checks have passed, although they are not reflected here: https://cirrus-ci.com/build/6066763053924352

I am not sure yet what the submit-queue check is, I have not seen it before.

fyi @fkorotkov

@fkorotkov

Copy link
Copy Markdown
Contributor

@Piinks this is the same thing that branch builds have a different set of tasks than PR builds. But the GH status should've been updated to neutral. Let me check if this change was deployed.

The submit queue check is coming from here https://github.com/cirruslabs/gh-submit-queue. I'll check why GH reports WIP as failing for master branch.

@Piinks

Piinks commented Mar 16, 2020

Copy link
Copy Markdown
Contributor Author

@fkorotkov Thanks for checking it out! I think this is ok to land then since checking Cirrus directly it looks like all the other checks have passed.

@fkorotkov

Copy link
Copy Markdown
Contributor

@Piinks sounds good. The change was not deployed and I've triggered a deploy now.

@Piinks
Piinks merged commit 48fc135 into master Mar 16, 2020
@Piinks

Piinks commented Mar 16, 2020

Copy link
Copy Markdown
Contributor Author

fyi @cyanglaz @blasten @kjlubick
This was reverted after breaking dart luci bots. I should be able to re-land after making a recipe change. There are a lot more repos running fluter tests on luci than I thought. 😜

@fkorotkov

Copy link
Copy Markdown
Contributor

Fixed WIP reporting in cirruslabs/gh-submit-queue@6f03db6

@tvolkert
tvolkert deleted the revert-49815-luciAuth branch March 29, 2020 21:02
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants