Skip to content

Reland "iOS UITextInput autocorrection prompt (#45354)" - #54119

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
LongCatIsLooong:reland-autocorrection
Apr 7, 2020
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
LongCatIsLooong:reland-autocorrection

Conversation

@LongCatIsLooong

Copy link
Copy Markdown
Contributor

reverted in #47373

This reverts commit bc67d22.

@fluttergithubbot fluttergithubbot added p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Apr 6, 2020
@LongCatIsLooong
LongCatIsLooong force-pushed the reland-autocorrection branch from 7215243 to 2ac4aeb Compare April 6, 2020 19:39

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chingjun

chingjun commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

This was reverted because of a new method added that broke our internal clients. I noticed that there's still a class that implements TextInputClient, can you make sure that the internal client will not be broken by this PR? Thanks.

@chingjun chingjun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit 4af5fe2 into flutter:master Apr 7, 2020
@LongCatIsLooong
LongCatIsLooong deleted the reland-autocorrection branch April 7, 2020 19:11
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants