Skip to content

Remove escape dollar parameter in localizations_utils - #54219

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
shihaohong:remove-escape-dollar
Apr 8, 2020
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
shihaohong:remove-escape-dollar

Conversation

@shihaohong

@shihaohong shihaohong commented Apr 7, 2020 •

Copy link
Copy Markdown
Contributor

Removes the escape dollar flag from generateString, since it is no longer being used by any of the l10n tools as a result of the fix in #54185

@shihaohong shihaohong added the a: internationalization Supporting other languages or locales. (aka i18n) label Apr 7, 2020
@shihaohong
shihaohong requested a review from HansMuller April 7, 2020 19:29
@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 7, 2020
@shihaohong shihaohong changed the title Remove escape dollar parameter Remove escape dollar parameter in localizations_utils Apr 8, 2020

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit 592f788 into flutter:master Apr 8, 2020
@shihaohong
shihaohong deleted the remove-escape-dollar branch May 14, 2020 00:37
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: internationalization Supporting other languages or locales. (aka i18n) c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants