Repository navigation
Gallery home page header color should track the material theme - #5486
Merged
Merged
Conversation
Contributor
|
Is there something worth testing here? |
Contributor
Author
|
A test that verified this would be a bit fragile, since it would depend on strings and colors could change and bit complicated, since it would depend on orchestrating a series of animated transitions. I don't think this change is worth testing. |
HansMuller
force-pushed
the
gallery_home_headings
branch
from
August 18, 2016 19:45
ae535ac to
0bd7fc6
Compare
Contributor
Author
|
cc @mpcomplete |
Contributor
|
LGTM |
Contributor
|
IMHO, the proper "test" for this bug is to fix #5491, which will cause existing tests to blow up with an exception. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5362